Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaFX wizard names and move DukeScript wizard to a better position. #6551

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 10, 2023

  • Its now closer to other frontend templates, like JavaFX, and has a more specific name
  • Remove the "(Gluon)" postfix from the JavaFX templates since they don't seem to use anything from gluon

image

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Oct 10, 2023
@mbien mbien added this to the NB20 milestone Oct 10, 2023
Its now closer to other frontend templates, like JavaFX, and has a
more specific name.

Remove the "(Gluon)" postfix from the JavaFX templates since they
don't seem to use anything from gluon.
@mbien mbien force-pushed the update-dukescript-wizard-category branch from d58bdb3 to f384c5b Compare October 10, 2023 06:38
@mbien mbien changed the title Move DukeScript wizard to a better position. Update JavaFX wizard names and move DukeScript wizard to a better position. Oct 10, 2023
@mbien mbien added JavaFX [ci] enable JavaFX job UI User Interface labels Oct 10, 2023
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Better than nothing - in some ways I'd prefer to remove it entirely.

Should it be Dukescript or Apache NetBeans HTML/Java API ? Mind you development of this seems to have stalled(?) and the build job has been failing for ages - https://github.com/apache/netbeans-html4j

@mbien
Copy link
Member Author

mbien commented Oct 10, 2023

i mean I have nothing against removing the dukescript pieces. If the embedded browser isn't used anywhere it might even allow NB to drop bundled javafx (which is a fairly large dependency).

The main reason I renamed it was because I end up in that wizard from time to time by accident, then realizing that its clearly not what I expected it to be.

thanks for taking a look -> merging

@mbien mbien merged commit ee97428 into apache:master Oct 10, 2023
@neilcsmith-net
Copy link
Member

NB to drop bundled javafx (which is a fairly large dependency).

Well, we don't bundle it, and the web view we never could as it's LGPL. All uses need to remain optional, so this wizard should really drop back to displaying something useful when its dependency cannot be met. Still, discussion for elsewhere.

Thanks for the change. Have had multiple discussions with end users ending up in that wizard also by accident!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaFX [ci] enable JavaFX job UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants